Add a list of Windows apps with known compatibility issues #8

AlexandrPkhm · 2025-10-21T13:01:45Z

Add a list of Windows apps with known compatibility issues

ameshkov

I don't like this format, check how it's done in Android. We may need structured data in the future.

You should also add the description to README

…g exclusions.

windows/http_filtering_exclusions_apps.json

windows/browsers.txt

README.md

windows/http_filtering_exclusions_apps.json

…t decided on yet.

…ner.exe to routing_exclusions.json

…ting_exclusions.json

Alex-302 · 2025-10-31T17:13:22Z

README.md

 ## What AdGuard applications use these filtering lists?

-Currently, they apply to AdGuard for Android.
+Currently, they apply to AdGuard for Android and AdGuard for Windows.


для макоси и клишных блокеров не актуально?

Пока нет, так как в них еще не реализован System wide filtering

ну почему, актуально для макоси, про это задача есть

…ing_exclusions.json

…uardTeam/AdguardForWindows#5721 to routing_exclusions.json

…ing_exclusions.json

Copilot

Pull request overview

Adds Windows-specific compatibility configuration lists to this repo so AdGuard for Windows can consume them alongside the existing Android lists.

Changes:

Added Windows app exclusion lists for routing and filtering behavior.
Added a Windows browser list used to enable HTTPS filtering by default for specific browsers.
Updated README to document Windows compatibility configuration files and their JSON schema.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File	Description
windows/routing_exclusions.json	New list of Windows apps whose traffic should not be routed through AdGuard.
windows/filtering_exclusions.json	New list of Windows apps whose traffic filtering should be disabled.
windows/browsers.json	New list of browsers + install-detection conditions for enabling HTTPS filtering by default.
README.md	Documents Windows config files and the common JSON entry structure.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

README.md

windows/browsers.json

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

ameshkov

Please address the PR comments

ameshkov · 2026-02-12T11:59:53Z

README.md

 ## What AdGuard applications use these filtering lists?

-Currently, they apply to AdGuard for Android.
+Currently, they apply to AdGuard for Android and AdGuard for Windows.


ну почему, актуально для макоси, про это задача есть

ameshkov · 2026-02-12T12:00:42Z

README.md

+Each application entry in the JSON files uses the following structure:
+
+- `name` - Application or browser display name
+- `file_description` - File description (optional, can be empty)


I suggest renaming file_description to description. As far as I understand it is supposed to be a compatibility issue description right?

ameshkov · 2026-02-12T12:01:38Z

README.md

+
+### Application model structure
+
+Each application entry in the JSON files uses the following structure:


Is it not explained which files from above should use this structure

ameshkov · 2026-02-12T12:34:37Z

windows/route_exclusions_apps.json

+[
+  {
+    "name": "iTunes",
+    "file_description": "",


Please fill the description where it's possible, explain the reason for having it in exclusions.

ameshkov · 2026-02-12T12:39:08Z

README.md

+
+- [`https_filtering_apps.json`](windows/https_filtering_apps.json) - A list of non-browser apps where HTTPS traffic filtering is enabled by default (App Management -> Filter HTTPS traffic).
+
+### Application model structure


I don't think it's a good idea to have identical structure for browsers.json and for different exclusions lists.

They have different purpose, and some fields only make sense in browsers and do not make any sense in other.

In browsers.json as far as I understand (@adbuker please correct me if I am wrong)

file_description - used for detecting processes to filter?

installed_conditions - only makes sense for browsers.json

At the same time, public_issue_url and private_issue_id only make sense in the files for exclusions.

file_description - used for detecting processes to filter?

Btw, if this is true, I'd say it would be better to structure a browser record like this:

{ "name": "Google Chrome", "routing_conditions": { "file_description": "Google Chrome", "executable_names": [ "chrome.exe" ], }, "installed_conditions": [ // here go the installed conditions ] }

In this case we'll only need routing_conditions in the exclusions files.

Add a list of Windows apps with known compatibility issues

a227c56

AlexandrPkhm requested review from adbuker and ameshkov October 21, 2025 13:01

AlexandrPkhm self-assigned this Oct 21, 2025

AlexandrPkhm requested a review from zebrum October 21, 2025 13:07

ameshkov requested changes Oct 21, 2025

View reviewed changes

AlexandrPkhm added 2 commits October 22, 2025 01:51

Updated README.md and separated the app.txt into filtering and routin…

3813115

…g exclusions.

Updated README.md and separated the app.txt into filtering and routin…

f54a9bf

…g exclusions.

AlexandrPkhm requested a review from ameshkov October 21, 2025 21:52

Alex-302 reviewed Oct 22, 2025

View reviewed changes

windows/http_filtering_exclusions_apps.json Show resolved Hide resolved

ameshkov requested changes Oct 22, 2025

View reviewed changes

windows/browsers.txt Outdated Show resolved Hide resolved

README.md Show resolved Hide resolved

windows/http_filtering_exclusions_apps.json Show resolved Hide resolved

adbuker marked this pull request as draft October 22, 2025 13:29

AlexandrPkhm added 4 commits October 22, 2025 18:06

Updated README.md with browsers.txt description. File extension is no…

eb60a8d

…t decided on yet.

Remove upc.exe from routing_exclusions.json

7ed3212

Add the logioptionsplus.exe, logioptionsplus_updater.exe and nvcontai…

c1ff39c

…ner.exe to routing_exclusions.json

Add the requested apps from AdguardTeam/AdguardForWindows#5611 to rou…

171dd6a

…ting_exclusions.json

Alex-302 reviewed Oct 31, 2025

View reviewed changes

AlexandrPkhm and others added 9 commits November 5, 2025 17:04

Add the requested app from AdguardTeam/AdguardForWindows#5705 to rout…

0d5e519

…ing_exclusions.json

Add the requested app from AdguardTeam/AdguardForWindows#5725 to rout…

7fee128

…ing_exclusions.json

Add the requested app from AdguardTeam/AdguardForWindows#5719 to rout…

f854635

…ing_exclusions.json

Add the requested app from AdguardTeam/AdguardForWindows#5719 and Adg…

89d521e

…uardTeam/AdguardForWindows#5721 to routing_exclusions.json

Add the requested app from AdguardTeam/AdguardForWindows#5773 to rout…

e67ce87

…ing_exclusions.json

Add the requested app from AdguardTeam/AdguardForWindows#5764 to rout…

3463676

…ing_exclusions.json

Add the requested app from AdguardTeam/AdguardForWindows#5794 to rout…

c7bb1f3

…ing_exclusions.json

add jsons

ef41454

add browsers

a94eddb

adbuker approved these changes Feb 10, 2026

View reviewed changes

ameshkov requested a review from Copilot February 10, 2026 15:01

Copilot started reviewing on behalf of ameshkov February 10, 2026 15:02 View session

Copilot AI reviewed Feb 10, 2026

View reviewed changes

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

windows/browsers.json Outdated Show resolved Hide resolved

windows/browsers.json Outdated Show resolved Hide resolved

windows/browsers.json Outdated Show resolved Hide resolved

AlexandrPkhm marked this pull request as ready for review February 10, 2026 15:16

adbuker and others added 7 commits February 10, 2026 18:35

Apply suggestion from @Copilot

5694a86

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Apply suggestion from @Copilot

7bf44ae

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Apply suggestion from @Copilot

7b1d35c

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update README.md

080c206

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update windows/browsers.json

1e6b124

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

reorder jsons

f71e4bd

resolve comments

9868404

ameshkov requested changes Feb 12, 2026

View reviewed changes


		### Application model structure

		Each application entry in the JSON files uses the following structure:


		- [`https_filtering_apps.json`](windows/https_filtering_apps.json) - A list of non-browser apps where HTTPS traffic filtering is enabled by default (App Management -> Filter HTTPS traffic).

		### Application model structure

Add a list of Windows apps with known compatibility issues #8

Are you sure you want to change the base?

Add a list of Windows apps with known compatibility issues #8

Conversation

AlexandrPkhm commented Oct 21, 2025

Uh oh!

ameshkov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ameshkov left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants